Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining ES5 built-ins/RegExp tests #2957

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix remaining ES5 built-ins/RegExp tests #2957

merged 1 commit into from
May 23, 2023

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Fix remaining ES5 built-ins/RegExp tests
  • Don't allocate on every match check

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels May 23, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone May 23, 2023
@HalidOdat HalidOdat requested a review from a team May 23, 2023 04:03
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,990 93,990 0
Passed 74,603 74,605 +2
Ignored 17,489 17,489 0
Failed 1,898 1,896 -2
Panics 0 0 0
Conformance 79.37% 79.38% +0.00%
Fixed tests (2): 
test/built-ins/RegExp/S15.10.2.7_A2_T1.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.2.7_A2_T1.js (previously Failed)

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #2957 (e8a36d6) into main (fdf9444) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2957      +/-   ##
==========================================
- Coverage   50.39%   50.15%   -0.24%     
==========================================
  Files         444      446       +2     
  Lines       45349    45761     +412     
==========================================
+ Hits        22854    22953      +99     
- Misses      22495    22808     +313
Impacted Files Coverage Δ
boa_engine/src/builtins/regexp/mod.rs 63.54% <100.00%> (+0.05%) ⬆️

... and 48 files with indirect coverage changes

@Razican Razican added this pull request to the merge queue May 23, 2023
Merged via the queue into main with commit 57ba979 May 23, 2023
@HalidOdat HalidOdat deleted the fix/es5-regexp-tests branch May 23, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@raskad raskad raskad approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @Razican @raskad